On Mon, Mar 9, 2015 at 8:36 PM, Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> wrote: > Paul Tan <pyokagan@xxxxxxxxx> writes: >> +' >> +test_expect_success 'xdg credentials file will not be created if it does not exist' ' > > We usually put a blank line between tests. Okay, will do that. >> +helper_test store > > That seems a bit "brute force" to me to re-run all tests several times. > It's probably OK since the tests are quite fast though. The credential helper tests are re-run because I believe that tests should make no assumptions on the underlying implementation. e.g. the presence of the xdg file only may activate a code path that causes credential storage to succeed but retrieval to fail. >> +test_expect_success 'set up custom XDG_CONFIG_HOME credential file' ' >> + XDG_CONFIG_HOME="$HOME/xdg" && export XDG_CONFIG_HOME && >> + mkdir -p "$HOME/xdg/git" && > > I'd spell that "$XDG_CONFIG_HOME"/git instead, but that's not really > important. Okay, will do that. Thanks for the review. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html