Jeff King <peff@xxxxxxxx> writes: > However, that is _not_ what we currently do with run-command's > use_shell directive. There we put SHELL_PATH as argv[0], and run: > > execv(argv[0], argv); > ... > If we want to maintain consistency with the rest of our uses of > run-command, it would be just your original: > > execl(SHELL_PATH, SHELL_PATH, "-c", shell_cmd.buf, NULL); > > That makes the most sense to me, unless we are changing run-command's > behavior, too. OK, then the original under discussion is fine as-is. Thanks for sanity checking. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html