Re: [PATCH] t7510: do not fail when gpg warns about insecure memory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mar 8, 2015, at 18:22, brian m. carlson wrote:

On Sun, Mar 08, 2015 at 06:15:55PM -0400, Eric Sunshine wrote:
On Sun, Mar 8, 2015 at 6:04 PM, brian m. carlson
<sandals@xxxxxxxxxxxxxxxxxxxx> wrote:
Perhaps this is better?

Unfortunately when running the test, that message is found in the standard output of git show -s --show-signature, but in the standard error of git verify-commit -v causing the comparisons of both standard output and
standard error to fail.

That doesn't help me parse it any better.  It's the "but" without a
corresponding "not" which seems to be throwing me off. Typically, one
would write "this but not that" or "not this but that". I can't tell
if there is a "not" missing or if the "but" is supposed to be an "and"
or if something else was intended.

The intended meaning is "and" with the additional sense of contrast. The sentence, if read with verbal emphasis, is, "…is found in the standard *output* of git show -s --signature, but in the standard *error* of git verify-commit -v", thus demonstrating why the test fails: the pairs of output files don't match up.

Maybe you can suggest a less confusing wording.

I like Brian's wording, but how about this slight variation, does this parse any better for you?

Unfortunately when running the test, while that message is found in
the standard output of git show -s --show-signature, it is found in
the standard error of git verify-commit -v causing the comparisons
of both standard output and standard error to fail.

-Kyle

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]