Re: [PATCH 1/2] reset: allow "-" short hand for previous commit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Sudhanshu Shekhar <sudshekhar02@xxxxxxxxx> writes:

> +		if(!strcmp(argv[0], "-")) {
[...]
> diff --git a/builtin/reset.c b/builtin/reset.c
> index 9f8967d..02f33ef 100644
> --- a/builtin/reset.c
> +++ b/builtin/reset.c
> @@ -206,7 +206,7 @@ static void parse_args(struct pathspec *pathspec,
>  	 */
>  
>  	if (argv[0]) {
> -		if(!strcmp(argv[0], "-")) {
> +		if (!strcmp(argv[0], "-")) {

Please, squash this hunk into the previous patch, so that reviewers get
the right version right away.

Also, send each patch as a separate email (git send-email can do that
for you).

> +	test_must_fail git reset - 2> output &&

Here and elsewhere: no space after >.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]