"brian m. carlson" <sandals@xxxxxxxxxxxxxxxxxxxx> writes: > Certain parts of the code have to be converted before others to keep the > patch sizes small, maintainable, and bisectable, so functions and > structures that are used across the codebase (e.g. struct object) will > be converted later. Conversion has been done in a somewhat haphazard > manner by converting modules with leaf functions and less commonly used > structs first. That "leaf-first" approach sounds very sensible. In the medium term, I wonder if the changes can progress faster and in a less error prone way if you first used GIT_SHA1_RAWSZ in places that cannot be immediately converted to the struct yet. That way, we will be easily tell by "git grep GIT_SHA1_RAWSZ" how many more places need treatment. I do not know if that is all that useful offhand, though. Those places need to be touched in the second pass to use the struct again, after the "s/\[20\]/[GIT_SHA1_RAWSZ]/" first pass. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html