Re: [PATCH] Remove use of git-rev-parse and replace git-rev-list --pretty with git-log

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Andy Parkins <andyparkins@xxxxxxxxx> writes:

> Linus noticed:
>
> --- >8 ---
> it should just avoid git-rev-parse these days and do
>
>   git rev-list --pretty $newrev --not --all
>
> instead. And quite frankly, rather than "git rev-list --pretty", there's
> no real reason not to do
>
>   git log $newrev --not --all
> --- 8< ---
>
> This patch makes those changes.
>
> Signed-off-by: Andy Parkins <andyparkins@xxxxxxxxx>

Please look at your Subject: line above and ponder how it would
look in the next issue of "What's cooking in git.git".  Do I
have to spend extra brain cycles to go back to "git log --stat"
and realize that this one only updates a sample hook script?

Also, please don't do "--- >8 ---".  If you want to, please use
two dashes; this is purely for technical reasons.

I'll massage the log message and move "^$base --not" around as
Linus suggested, but next time please be a bit more careful.

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]