Luis Ressel <aranea@xxxxxxxx> writes: > Oh, and should I add a testcase for the new functionality introduced by > this patch? And if yes, what exactly should I test? Absolutely. Thinking things through to design what needs to be tested is part of the exercise ;-) You need to demonstrate that the new feature kicks in when it should, and also you need to make sure the new feature does not get used when it shouldn't. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html