On March 3, 2015 11:30:13 PM GMT+05:30, Junio C Hamano <gitster@xxxxxxxxx> wrote: >On Tue, Mar 3, 2015 at 8:22 AM, Matthieu Moy ><Matthieu.Moy@xxxxxxxxxxxxxxx> wrote: >> Karthik Nayak <karthik.188@xxxxxxxxx> writes: >> >>> now it works like cd "" which silently succeeds >> >> Missing "." at end of sentence. > >And lack of capitalization at the beginning. Yes, noted, Will fix with next patch. > >More importantly, lack of justification--why is it a good idea to make >"it works like cd ''" in the first place? > >> >>> git.c | 4 +++- >> >> That would probably also deserve a test. Will include a patch with next patch version. > >Another "huh?" I had on the actual code was if this counts as >"envchanged", if >you are not actually changing the directory at all. > >Is this meant as a "micro" for GSoC, by the way? Yes, it's meant for GSoC. I did overlook that. Will fix in next patch version. Thanks for your suggestions -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html