Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> writes:
> Sudhanshu Shekhar <sudshekhar02@xxxxxxxxx> writes:
>
>> From: SudShekhar <sudshekhar02@xxxxxxxxx>
>
> Please, set your configuration to have the same identity for commit and
> send-email. It seems your commiter ID (user.name) does not contain your
> last name.
Actually, the token does not match either of the two names; it looks
like two names smashed together into a single nickname token.
>> builtin/reset.c | 2 ++
>
> Doesn't this deserve a test?
>
> + if(!strcmp(argv[0],"-"))
> + argv[0]="@{-1}";
>
> Wrong spacing (around = and after ,).
What should worry us even more is what the user would get when @{-1}
does not resolve to something the command can use. It would be bad
if we give an error message with @{-1} in it that the user never
typed (and may not even understand what it means).
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html