On Wed, Feb 25, 2015 at 6:56 AM, Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> wrote: > To get an idea, I counted the lines of code written by the student I > mentored last year: > > $ git log --author tanayabh@xxxxxxxxx -p | diffstat -s > 43 files changed, 1225 insertions(+), 367 deletions(-) > > I would consider this GSoC as "average" (i.e. not exceptionnally good, > but certainly not a bad one either), so you may hope for more, but you > should not _expect_ much more IMHO. > > In comparison: > > $ wc -l git-add--interactive.perl > 1654 git-add--interactive.perl > $ wc -l git-stash.sh > 617 git-stash.sh > > I'd expect a rewrite in C to at least double the number of lines of > code, so rewriting git-stash would mean writting at least as many lines > of code as the GSoC above. git-add--interactive.perl would be rather far > above. > > But my point was not to convert _only_ git-pull.sh, but to have a GSoC > starting with this one and plan more. Then, depending on how it goes, > you can adjust the target. Some data point as I have a half-baked builtin/pull.c in my (forgotten) private branch for 3 years. pull.c has 389 lines (with 24 shell lines left in "#if 0"). git-pull.sh has 340 lines. Let's add 100 C lines to pull.c when it's complete, that's 50% more lines. But in the git-pull case the student could get a good head start by reusing my code, maybe. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html