Jeff King <peff@xxxxxxxx> writes: > 3. The sort order check is wrong. :-/ It needs to take into account > git's magic "if it's a tree, pretend it has '/' after it" rule. > That's not too hard for a single tree (fsck.c:verify_ordered does > it). But for filepairs, I'm not sure what to do. Most cases > have a single mode/name pair. But what about a D/F typechange? If > "foo" becomes "foo/", which do I use to sort? I think diff-index populates the diff queue in a wrong order and then calls diffcore_fix_diff_index() to fix it up. I am a bit worried about the effect this stricter input check might have to "diff --no-index" codepath, though. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html