Junio C Hamano <gitster@xxxxxxxxx> writes: > Michael J Gruber <git@xxxxxxxxxxxxxxxxxxxx> writes: > >> Some commands use OPT_STRING to specify a <file> argument. Let them use >> OPT_FILENAME so that they can profit from path prefixing. > > If the existing code that takes string actually already works > correctly, they must be doing the necessary prefixing on their own, > but I do not see in this patch a hunk that removes such a custom > prefixing. Puzzled... > > It may be that some of them do not work correctly from subdirectory > and this change fixes bugs, but are all of them like that, or is > this patch fixing some of them while breaking some others? Ahh, I see Peff already went over the changes in the patch and sifted them into good, questionable and bad bins. Thanks; I'll shut up and await for a reroll ;-) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html