On Mon, Feb 23, 2015 at 05:17:45PM +0100, Michael J Gruber wrote: > diff --git a/builtin/clone.c b/builtin/clone.c > index a9af3f2..15941c5 100644 > --- a/builtin/clone.c > +++ b/builtin/clone.c > @@ -80,7 +80,7 @@ static struct option builtin_clone_options[] = { > N_("initialize submodules in the clone")), > OPT_BOOL(0, "recurse-submodules", &option_recursive, > N_("initialize submodules in the clone")), > - OPT_STRING(0, "template", &option_template, N_("template-directory"), > + OPT_PATH(0, "template", &option_template, N_("template-directory"), > N_("directory from which templates will be used")), > OPT_CALLBACK(0 , "reference", &option_reference, N_("repo"), > N_("reference repository"), &opt_parse_reference), I'm not sure if this one is doing anything. Clone cannot use SETUP_GIT for obvious reasons, so we should have a NULL prefix here. But that also means we should be doing the right thing already. I think the same goes for the rest of the instances in this patch. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html