Torsten Bögershausen <tboegi@xxxxxx> writes: > On 02/18/2015 07:40 PM, Junio C Hamano wrote: >> "brian m. carlson" <sandals@xxxxxxxxxxxxxxxxxxxx> writes: >> >>> I understand that this used to work, but it probably shouldn't have >>> ever been accepted. It's nonstandard, and if we accept it for ssh, >>> people will want it to work for https, and due to libcurl, it simply >>> won't. >>> >>> I prefer to see our past acceptance of this format as a bug. This is >>> the first that I've heard of anyone noticing this (since 2013), so it >>> can't be in common usage. >>> >>> If we accept it, we should explicitly document it as being deprecated >>> and note that it's inconsistent with the way everything else works. >> I was reviewing my Undecided pile today, and I think your objection >> makes sense. >> >> Either of you care to update documentation, please, before I drop >> this series and forget about it? > > The URL RFC is much stricter regarding which characters that are allowed > in which part of the URL, as least as I read it. > ... > I'm somewhat unsure what to write in the documentation, I must admit. I can see that you do not agree with the "If we accept it" part (where "it" refers to "allowing [...] was a bug.")---past acceptance was not a bug for you. Brian is for that "If we accept it", and sees it as a bug. So let's see what he comes up with as a follow-up to the "we should explicitly document it" part. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html