Jeff King <peff@xxxxxxxx> writes:
>> + if (!strcmp(k, "push.followtags")) {
>> + if (git_config_bool(k, v))
>> + *flags |= TRANSPORT_PUSH_FOLLOW_TAGS;
>> + else
>> + *flags &= ~TRANSPORT_PUSH_FOLLOW_TAGS;
>> + return 0;
>> + }
>
> Did you have an opinion on sticking this behind a helper function?
Not very strongly either way. Seeing the above does not bother me
too much, but I do not know how I would feel when I start seeing
val = git_config_book(k, v);
flip_bool(val, &flags, TRANSPORT_PUSH_FOLLOW_TAGS);
often. Not having to make sure that the bit constant whose name
tends to get long is not misspelled is certainly a plus.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html