On Fri, Feb 13, 2015 at 12:19:27PM -0800, Junio C Hamano wrote:
The first one is a replay of Kyle's workaround for older versions of Getopt::Long that did not take "--no-option" to negate a boolean option "--option". The second one revert the workarounds made to the test script over time, and should break if the first one does not work well for older Getopt::Long (I have no reason to suspect it would break, though). I am inclined to squash these into one commit before starting to merge them down to 'next' and then to 'master', after getting Tested-by: from those with older Getopt::Long (prior to 2.32). Obviously, tc/t9001-noxmailer topic will become unnecessary and be dropped when that happens.
I think this is a good fix. It preserves the documented behavior even on less capable systems.
-- brian m. carlson / brian with sandals: Houston, Texas, US +1 832 623 2791 | http://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: RSA v4 4096b: 88AC E9B2 9196 305B A994 7552 F1BA 225C 0223 B187
Attachment:
signature.asc
Description: Digital signature