On 02/12/2015 10:54 PM, Jeff King wrote:
> On Mon, Feb 09, 2015 at 10:12:42AM +0100, Michael Haggerty wrote:
>
>> if (!(flags & EXPIRE_REFLOGS_DRY_RUN)) {
>> + /*
>> + * It doesn't make sense to adjust a reference pointed
>> + * to by a symbolic ref based on expiring entries in
>> + * the symbolic reference's reflog.
>> + */
>> + int update = (flags & EXPIRE_REFLOGS_UPDATE_REF) &&
>> + ~(type & REF_ISSYMREF);
>> +
>
> Isn't this second clause tautological? Unless REF_ISSYMREF covers all
> bits in "type", then "type & REF_ISSYMREF" must always have at least one
> bit 0, and negating it becomes non-zero. Did you mean:
>
> !(type & REF_ISSYMREF)
>
> ?
You're right, of course. Thanks.
Michael
--
Michael Haggerty
mhagger@xxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html