On Tue, Feb 10, 2015 at 02:52:23PM -0800, Stefan Beller wrote: > On Mon, Feb 9, 2015 at 1:12 AM, Michael Haggerty <mhagger@xxxxxxxxxxxx> wrote: > > None of the callers pass NULL to this function, and there doesn't seem > > to be any usefulness to allowing them to do so. > > Usually I'd oppose this change, as it seems to be a good defensive > measure. (I cannot assume future me or anybody knows what they're > doing), but as this function (write_ref_sha1) is not widely exposed > any more since aae383db8 (Apr 28, refs.c: make write_ref_sha1 static), > I think it's safe to assume changes affecting this call are well > understood in the future. Thanks, I was iffy on this change for the same reason, but after your explanation, I too think it is reasonable. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html