Re: [PATCH v2 3/4] apply: do not read from beyond a symbolic link

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 3, 2015 at 11:37 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Stefan Beller <sbeller@xxxxxxxxxx> writes:
>
>> On Mon, Feb 2, 2015 at 3:27 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>>> +       test_must_fail git apply --index patch
>>> +
>>> +'
>>
>> Is the empty line between the last test_must_fail and the closing `'`
>> intentional?
>
> I think I just mimicked the previous existing one, but I can go with
> the version without.

It was really a honest question. I've seen and written and sent tests
without such an ending
empty line and it seemed to be ok.

Maybe my email was more of "Note to self: this is also a valid style
used in the test suite
at some places"
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]