On 02/02/2015 05:48 PM, Johannes Schindelin wrote:
> On 2015-02-02 13:43, Michael Haggerty wrote:
>> On 02/02/2015 12:41 PM, Johannes Schindelin wrote:
>>> Hi all (in particular Junio),
>>>
>>> On 2015-01-31 22:04, Johannes Schindelin wrote:
>>>
>>>> [...] switch to fsck.severity to address Michael's concerns that
>>>> letting fsck.(error|warn|ignore)'s comma-separated lists possibly
>>>> overriding each other partially;
>>>
>>> Having participated in the CodingStyle thread, I came to the
>>> conclusion that the fsck.severity solution favors syntax over
>>> intuitiveness.
>>>
>>> Therefore, I would like to support the case for
>>> `fsck.level.missingAuthor` (note that there is an extra ".level." in
>>> contrast to earlier suggestions).
>>
>> Why "level"?
>
> "Severity level", or "error level". Maybe ".severity." would be better?
Sorry, I should have been clearer. I understand why the word "level"
makes sense, as opposed to, say, "peanut-butter". What I don't
understand is why a middle word is needed at all. In the config file it
will look like
[fsck "level"]
missingAuthor = error
, which looks funny. "level" is a constant, so it seems superfluous.
If anything, it might be more useful to allow an optional middle word to
allow the strictness level to be adjusted based on which command
encounters the problem. For example, if you want to tolerate existing
commits that have missing authors, but not allow any new ones to be
pushed, you could set
[strictness]
missingAuthor = ignore
[strictness "receive-pack"]
missingAuthor = error
(There's probably a better word than "strictness", but you get the idea.)
>>> The benefits:
>>>
>>> - it is very, very easy to understand
>>>
>>> - cumulative settings are intuitively cumulative, i.e. setting
>>> `fsck.level.missingAuthor` will leave `fsck.level.invalidEmail`
>>> completely unaffected
>>>
>>> - it is very easy to enquire and set the levels via existing `git
>>> config` calls
>>>
>>> Now, there is one downside, but *only* if we ignore Postel's law.
>>>
>>> Postel's law ("be lenient in what you accept as input, but strict in
>>> your output") would dictate that our message ID parser accept both
>>> "missing-author" and "missingAuthor" if we follow the inconsistent
>>> practice of using lowercase-dashed keys on the command-line but
>>> CamelCased ones in the config.
>>>
>>> However, earlier Junio made very clear that the parser is required to
>>> fail to parse "missing-author" in the config, and to fail to parse
>>> "missingAuthor" on the command-line.
>>>
>>> Therefore, the design I recommend above will require two, minimally
>>> different parsers for essentially the same thing.
>>>
>>> IMHO this is a downside that is by far outweighed by the ease of use
>>> of the new feature, therefore I am willing to bear the burden of
>>> implementation.
>>
>> I again encourage you to consider skipping the implementation of
>> command-line options entirely. It's not like users are going to want to
>> use different options for different invocations. Let them use
>>
>> git -c fsck.level.missingAuthor=ignore fsck
>>
>> if they really want to play around, then
>>
>> git config fsck.level.missingAuthor ignore
>>
>> to make it permanent. After that they will never have to worry about
>> that option again.
>
> Unfortunately, I have to pass the `receive.fsck.*` settings from
> `git-receive-pack` to `git-unpack-objects` or `git-index-pack` via the
> command-line, because it is `git-receive-pack` that consumes the config
> setting, but it is one of `git-unpack-objects` and `git-index-pack` that
> has to act on it...
Wouldn't that work automatically via the GIT_CONFIG_PARAMETERS
mechanism? If I run
git -c foo.bar=baz $CMD
, then git-$CMD is invoked with GIT_CONFIG_PARAMETERS set to
"'foo.bar=baz'", which causes child processes to treat that value as a
configuration setting. I don't have a lot of experience with this but I
think it should do what you need.
Michael
--
Michael Haggerty
mhagger@xxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html