On Mon, Feb 02, 2015 at 10:33:02AM -0800, Jonathon Mah wrote: > Signed-off-by: Jonathon Mah <me@xxxxxxxxxxxxxxx> > --- > Adjust prune test directly, much nicer. Agreed, this is much nicer. A few comments: > +test_expect_success 'prune: handle alternate object database' ' This test fails, so we either need expect_failure here, or it just needs to be squashed in with the fix (I generally prefer the latter). > + test_create_repo A && cd A && We generally prefer to chdir in a subshell, so that a failure in the test does not leave further tests in a confusing spot. Like: test_create_repo A && ( cd A && ... do stuff in repo ... # no need to cd .. ) && .. do stuff outside repo ... > + echo "Hello World" > file1 && Style nit: we prefer ">file1" with no space. > + git add file1 && > + git commit -m "Initial commit" file1 && > + cd .. && > + git clone -l -s A B && cd B && "-l" is a noop these days. I don't think it is hurting, but I'd prefer not to propagate bad habits in our tests. > diff --git a/t/t5710-info-alternate.sh b/t/t5710-info-alternate.sh > index 5a6e49d..d82844a 100755 > --- a/t/t5710-info-alternate.sh > +++ b/t/t5710-info-alternate.sh We can drop this change, then, right? -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html