Now we only have one place where we need to touch the internals of the lock_file struct. No functional changes intended. Signed-off-by: Stefan Beller <sbeller@xxxxxxxxxx> --- refs.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/refs.c b/refs.c index 8281bed..311599b 100644 --- a/refs.c +++ b/refs.c @@ -3064,6 +3064,13 @@ int is_branch(const char *refname) return !strcmp(refname, "HEAD") || starts_with(refname, "refs/heads/"); } +static ssize_t write_in_full_to_lockfile(struct lock_file *lock, + const void *buf, + size_t count) +{ + return write_in_full(lock->fd, buf, count); +} + /* * Write sha1 into the ref specified by the lock. Make sure that errno * is sane on error. @@ -3097,8 +3104,8 @@ static int write_ref_sha1(struct ref_lock *lock, errno = EINVAL; return -1; } - if (write_in_full(lock->lk->fd, sha1_to_hex(sha1), 40) != 40 || - write_in_full(lock->lk->fd, &term, 1) != 1 || + if (write_in_full_to_lockfile(lock->lk, sha1_to_hex(sha1), 40) != 40 || + write_in_full_to_lockfile(lock->lk, &term, 1) != 1 || close_ref(lock) < 0) { int save_errno = errno; error("Couldn't write %s", lock->lk->filename.buf); @@ -4078,9 +4085,9 @@ int reflog_expire(const char *refname, const unsigned char *sha1, status |= error("couldn't write %s: %s", log_file, strerror(errno)); } else if ((flags & EXPIRE_REFLOGS_UPDATE_REF) && - (write_in_full(lock->lk->fd, + (write_in_full_to_lockfile(lock->lk, sha1_to_hex(cb.last_kept_sha1), 40) != 40 || - write_in_full(lock->lk->fd, "\n", 1) != 1 || + write_in_full_to_lockfile(lock->lk, "\n", 1) != 1 || close_ref(lock) < 0)) { status |= error("couldn't write %s", lock->lk->filename.buf); -- 2.2.1.62.g3f15098 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html