Re: [PATCH 20/24] update-index: test the system before enabling untracked cache

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Duy Nguyen <pclouds@xxxxxxxxx> writes:

> On Wed, Jan 21, 2015 at 3:32 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>> Nguyễn Thái Ngọc Duy  <pclouds@xxxxxxxxx> writes:
>>
>>> Helped-by: Eric Sunshine <sunshine@xxxxxxxxxxxxxx>
>>> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx>
>>> Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx>
>>> ---
>>
>> It appears that this hijacks a fixed name dir-mtime-test at the root
>> level of every project managed by Git.  Is that intended?
>
> I did think about filename clash, but I chose a fixed name anyway for
> simplicity, otherwise we would need to reconstruct paths
> "dir-mtime-test/..." in many places.

If you stuff the name of test directory (default "dir-mtime-test")
in a strbuf and formulate test paths by chomping to the original and
then appending "/..." at the end, like your remove_test_directory()
already does, wouldn't that be sufficient?

>> Shouldn't --use-untracked-cache option require the working tree
>> (i.e. die in a bare repository)?
>
> setup_work_tree() takes care of that

OK, thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]