Robin Rosenberg <robin.rosenberg@xxxxxxxxxx> wrote:
> + public String getPatch() throws IOException {
> + final File ptr = new File(getDirectory(),"patches/"+getBranch()+"/current");
> + final BufferedReader br = new BufferedReader(new FileReader(ptr));
> + final String line = br.readLine();
> + return line;
> + }
Last time I checked leaking a file descriptor was a bad idea.
I fixed it (in both methods) when I applied the patch.
Your whole series is now pushed. Thanks for the cleanups.
--
Shawn.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html