On Thu, Jan 15, 2015 at 12:36:00PM -0800, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > FWIW, the full set of CFLAGS I use (which I specify in config.mak) is: > > > > CFLAGS += -Wall -Werror > > CFLAGS += -Wno-format-zero-length > > CFLAGS += -Wdeclaration-after-statement > > CFLAGS += -Wpointer-arith > > CFLAGS += -Wstrict-prototypes > > CFLAGS += -Wold-style-declaration > > I think I have no-pointer-to-int-cast, old-style-definition and vla > in addition to the above. Thanks, I added the latter two to my setup. But what is the purpose of turning off pointer-to-int warnings? It seems like those are a good indication of a sloppy construct (and AFAICT, we do not have any code which triggers on it). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html