On Jan 12, 2015, at 18:28, Jeff King wrote:
When we fetch a symbolic ref file from the remote, we get
the whole string "ref: refs/heads/master\n", recognize it by
skipping past the "ref: ", and store the rest. We should
chomp the trailing newline.
[..]
This is a regression in v2.1.0.
It was causing t5540 to fail, but I realized I have been building with
NO_EXPAT for a while, so I didn't notice. Frankly, I'm kind of
surprised
and disturbed that nobody noticed it before now. More evidence that we
can kill off dumb http-push? I would have thought somebody else would
have noticed the test failure, though.
I have this line in my 2.1.4 test output log:
t5540-http-push-webdav.sh .......................... ok
And again in my 2.2.2 test output log:
t5540-http-push-webdav.sh .......................... ok
Running the 2.2.2 version with -v I get:
t5540-http-push-webdav.sh ..
ok 1 - setup remote repository
ok 2 - create password-protected repository
ok 3 - setup askpass helper
ok 4 - clone remote repository
ok 5 - push to remote repository with packed refs
ok 6 - push already up-to-date
ok 7 - push to remote repository with unpacked refs
ok 8 - http-push fetches unpacked objects
ok 9 - http-push fetches packed objects
ok 10 - create and delete remote branch
ok 11 - MKCOL sends directory names with trailing slashes
ok 12 - PUT and MOVE sends object to URLs with SHA-1 hash suffix
ok 13 - non-fast-forward push fails
ok 14 - non-fast-forward push show ref status
ok 15 - non-fast-forward push shows help message
not ok 16 - force with lease aka cas # TODO known breakage
ok 17 - push to password-protected repository (user in URL)
not ok 18 - user was prompted only once for password # TODO known
breakage
not ok 19 - push to password-protected repository (no user in URL) #
TODO known breakage
# still have 3 known breakage(s)
# passed all remaining 16 test(s)
1..19
ok
I also get the same results using v2.3.0-rc0.
I do not build with NO_EXPAT. This is running the tests on OS X
without this patch applied. Is something else required to get a
failure?
-Kyle
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html