On Mon, Jan 12, 2015 at 06:21:19PM -0800, Jonathan Nieder wrote:
> Jeff King wrote:
>
> > --- a/git-compat-util.h
> > +++ b/git-compat-util.h
> > @@ -675,6 +675,11 @@ extern char *xgetcwd(void);
> >
> > #define REALLOC_ARRAY(x, alloc) (x) = xrealloc((x), (alloc) * sizeof(*(x)))
> >
> > +static inline char *xstrdup_or_null(const char *str)
> > +{
> > + return str ? xstrdup(str) : NULL;
> > +}
>
> Would it make sense for xstrdup to always include the NULL check,
> avoiding the need for the more verbose xstrdup_or_null?
Read the rest of the thread. :)
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html