On Tue, Jan 06, 2015 at 03:13:30PM -0800, Junio C Hamano wrote: > > The problem is in the t/perf/perf-lib.sh:test_perf_create_repo_from() > > function, where we see this: > > > > repo="$1" > > source="$2" > > source_git=$source/$(cd "$source" && git rev-parse --git-dir) > > > > The function is invoked as: > > > > test_perf_create_repo_from '/home/psmith/src/git-2.2.1/t/perf/trash > > directory.p5302-pack-index' /home/psmith/src/git-2.2.1/t/.. > > > > but this doesn't work, because "$source" is not a Git repository; it's > > the root of the unpacked tarball. > > Yup, that is exactly why I said I am not surprised. > > I do not think profile build is prepared to be run without having > our history (after all, it is not test_perf_create_REPO_from, not > test_perf_create_source_directory_of_git_from). It wants to create > a repository that hosts a reasonably sized but not too big a > project, i.e. us. > > The safest and cleanest fix would be to make sure that the said > function checks if $source/.git is a repository, perhaps? Hmph. We already dealt with this once in 93b5393 (Makefile: make perf tests optional for profile build, 2014-08-19). That check explicitly looks for ".git" (and not checking that we are in an outer git repo), so I am not sure why it is kicking in at all. But probably the fix should go there. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html