Re: [PATCH] git-svn: show progress in working_head_info()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ramkumar Ramachandra <artagnon@xxxxxxxxx> wrote:
> The working_head_info routine takes a very long time to execute on large
> repositories. The least we can do is to comfort users that some progress
> is being made.
> 
> Signed-off-by: Ramkumar Ramachandra <artagnon@xxxxxxxxx>
> ---
>  I was worried because of the long wait, so I wrote this to convince
>  myself that git-svn wasn't stuck.

Unfortunately, this breaks show-ignore and t9101-git-svn-props.sh

show-ignore.expect show-ignore.got differ: char 1, line 1
not ok 23 - test show-ignore

Perhaps output should go to STDERR and also respect $_q?

>  git-svn.perl | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/git-svn.perl b/git-svn.perl
> index 60f8814..6aa156c 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -2022,6 +2022,9 @@ sub working_head_info {
>  			next;
>  		}
>  		next unless s{^\s*(git-svn-id:)}{$1};
> +		my $chomped = $_;
> +		chomp $chomped;
> +		print "[Importing] $chomped\n";
>  		my ($url, $rev, $uuid) = extract_metadata($_);
>  		if (defined $url && defined $rev) {
>  			next if $max{$url} and $max{$url} < $rev;
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]