On Thu, Jan 8, 2015 at 3:00 PM, Reuben Hawkins <reubenhwk@xxxxxxxxx> wrote: > Detect 'tv_nsec' field in 'struct stat' and set Makefile variable > NO_NSEC appropriately. > > A side-effect of the above detection is that we also determine > whether 'stat.st_mtimespec' is available, so, as a bonus, set the > Makefile variable USE_ST_TIMESPEC, as well. > > Signed-off-by: Reuben Hawkins <reubenhwk@xxxxxxxxx> These patches may or may not deserve a Helped-by:. With or without the Helped-by: and the minor style fix-up below... Reviewed-by: Eric Sunshine <sunshine@xxxxxxxxxxxxxx> Thanks for the perseverance. For convenience of other reviewers: This is v3. v1 through v3 are threaded together here: http://thread.gmane.org/gmane.comp.version-control.git/261619 > --- > diff --git a/configure.ac b/configure.ac > index 6af9647..210eb4e 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -754,6 +754,19 @@ AC_CHECK_TYPES([struct itimerval], > [#include <sys/time.h>]) > GIT_CONF_SUBST([NO_STRUCT_ITIMERVAL]) > # > +# Define USE_ST_TIMESPEC=YesPlease when stat.st_mtimespec.tv_nsec exists. > +# Define NO_NSEC=YesPlease when neither stat.st_mtim.tv_nsec nor > +# stat.st_mtimespec.tv_nsec exists. > +AC_CHECK_MEMBER([struct stat.st_mtimespec.tv_nsec]) > +AC_CHECK_MEMBER([struct stat.st_mtim.tv_nsec]) > +if test x$ac_cv_member_struct_stat_st_mtimespec_tv_nsec = xyes ; then Style: For consistency with all other 'if' conditionals in configure.ac, drop the space before the semicolon. > + USE_ST_TIMESPEC=YesPlease > + GIT_CONF_SUBST([USE_ST_TIMESPEC]) > +elif test x$ac_cv_member_struct_stat_st_mtim_tv_nsec != xyes ; then Ditto. > + NO_NSEC=YesPlease > + GIT_CONF_SUBST([NO_NSEC]) > +fi > +# > # Define NO_D_INO_IN_DIRENT if you don't have d_ino in your struct dirent. > AC_CHECK_MEMBER(struct dirent.d_ino, > [NO_D_INO_IN_DIRENT=], > -- > 2.2.0.68.g8f72f0c.dirty -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html