Will research this question and resend the patch. Thank you. 2015-01-09 1:45 GMT+06:00 Junio C Hamano <gitster@xxxxxxxxx>: > Alexander Kuleshov <kuleshovmail@xxxxxxxxx> writes: > >> Signed-off-by: Alexander Kuleshov <kuleshovmail@xxxxxxxxx> >> --- >> builtin/cat-file.c | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/builtin/cat-file.c b/builtin/cat-file.c >> index f8d8129..750b5a2 100644 >> --- a/builtin/cat-file.c >> +++ b/builtin/cat-file.c >> @@ -4,12 +4,8 @@ >> * Copyright (C) Linus Torvalds, 2005 >> */ >> #include "cache.h" >> -#include "exec_cmd.h" >> -#include "tag.h" >> -#include "tree.h" >> #include "builtin.h" >> #include "parse-options.h" >> -#include "diff.h" >> #include "userdiff.h" >> #include "streaming.h" > > Interesting. > > - "exec_cmd.h" became unnecessary at b931aa5a (Call builtin ls-tree > in git-cat-file -p, 2006-05-26). > > - "tag.h" and "tree.h" became unnecessary at 21666f1a (convert > object type handling from a string to a number, 2007-02-26). > > - "diff.h" was added at e5fba602 (textconv: support for cat_file, > 2010-06-15), together with "userdiff.h". Was it unnecessary from > the beginning? > > I didn't dig further to find out the answer to the last question, > but a patch to remove these include should explain these in its log > message, I would think. > > Thanks. > > -- _________________________ 0xAX -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html