On Tue, Jan 6, 2015 at 4:58 PM, Michael Paquier <michael.paquier@xxxxxxxxx> wrote: > Hi all, > > While toying with the tab completion script for bash, I found a couple > of things missing that cannot be completed: > - git config --includes > - git config branch.$BRANCH_NAME.description > Attached are trivial patches based on master to fix those things. > Regards, > -- > Michael Thanks for your effort on improving git! Please have a look at Documentation/SubmittingPatches in git[1], specially section "(4) Sending your patches." so discussion on the patches is easier. >Do not attach the patch as a MIME attachment, compressed or not. >Do not let your e-mail client send quoted-printable. Do not let >your e-mail client send format=flowed which would destroy >whitespaces in your patches. Many >popular e-mail applications will not always transmit a MIME >attachment as plain text, making it impossible to comment on >your code. A MIME attachment also takes a bit more time to >process. This does not decrease the likelihood of your >MIME-attached change being accepted, but it makes it more likely >that it will be postponed. The easiest way to comply with all these rules outlined in SubmittingPatches is to use git format-patch and git send-email (as they follow the best practice). I recently wrote about my experiences when sending patches to the git mailing list, including how to configure git send-email[2], maybe that helps. Thanks, Stefan [1] for example it can be found at https://raw.githubusercontent.com/git/git/master/Documentation/SubmittingPatches [2]http://thread.gmane.org/gmane.comp.version-control.git/261900 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html