Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes: > Just a few comments and observations below. Alone, they are not > necessarily worth a re-roll, but if you happen to re-roll for some > other reason, perhaps take them into consideration. I actually think everything you said in this review makes sense and will make the resulting code a lot better (especially the part on the parsing loop). Thanks, as usual, for a careful reading. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html