Hi,
Alexander Kuleshov <kuleshovmail@xxxxxxxxx> writes:
> Signed-off-by: 0xAX <kuleshovmail@xxxxxxxxx>
Please use your full name for the sign-off.
> ---
> git-send-email.perl | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/git-send-email.perl b/git-send-email.perl
> index 82c6fea..6a995c4 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -1274,11 +1274,11 @@ X-Mailer: git-send-email $gitversion
> }
>
> if (!$smtp) {
> - die "Unable to initialize SMTP properly. Check config and use --smtp-debug. ",
> - "VALUES: server=$smtp_server ",
> - "encryption=$smtp_encryption ",
> - "hello=$smtp_domain",
> - defined $smtp_server_port ? " port=$smtp_server_port" : "";
> + die "Unable to initialize SMTP properly. Check config and use --smtp-debug.\n",
> + "VALUES: server=$smtp_server\n\t",
> + "encryption=$smtp_encryption\n\t",
> + "hello=$smtp_domain\n\t",
> + defined $smtp_server_port ? "port=$smtp_server_port\n" : "\n";
Minor nits:
- I think this would be easier to read if the \t was on the line which
should be indented.
- If $smtp_server_port is not defined we produce an unnecessary empty line
> }
>
> smtp_auth_maybe or die $smtp->message;
> --
> 2.2.1.202.g98acd41
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html