Hi,
On Wed, 28 Feb 2007, Andy Parkins wrote:
> + printf("%s%i%s", add_c, added, reset);
Please use "%d" instead of "%i" (I forgot why, but I remember Junio saying
that we should do it...).
> + if (added != 0 && deleted != 0 )
> + printf(" -> ");
Either you want to have
Bin +123456 bytes
or
Bin 0 -> 123456 bytes
for added files (and the obvious thing for deleted ones), but with your
patch, both added and deleted get
Bin 123456 bytes
which is not so optimal.
Ciao,
Dscho
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html