Hi Junio, On Tue, 23 Dec 2014, Junio C Hamano wrote: > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > > And *still*, this is *just* a global table with defaults. I would *still* > > need to copy-on-write when the first customization of the severity level > > takes place because I cannot allow the global defaults to be modified by > > one caller (that would defeat the whole purpose of having per-caller > > settings bundled in the fsck_options struct). > > If you allocate a per-invocation fsck_options struct, then the > initialization the default with code is dead easy---you can just do > it immediately after you x[cm]alloc()---no? There is no alloc. Right now, the initialization reads: struct fsck_options options = strict ? FSCK_OPTIONS_STRICT : FSCK_OPTIONS_DEFAULT; Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html