Re: git-remote and remotes with '.' in their names

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, 28 Feb 2007, Paolo Bonzini wrote:

> Hello,
> 
> >  	for (@remotes) {
> > -		if (/^remote\.([^.]*)\.(\S*)\s+(.*)$/) {
> > +		if (/^remote\.(.*)\.(\S*)\s+(.*)$/) {
> 
> You probably want either
> 
> +		if (/^remote\.(\S*)\.(\S*)\s+(.*)$/) {
> 
> or
> 
> +		if (/^remote\.(\S*)\.([^.]*)\s+(.*)$/) {

Did you mean to prevent the remote starting with a dot? IMHO that would be 
a good change, but AFAIS both your proposals don't do that.

Ciao,
Dscho

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]