Junio C Hamano <gitster@xxxxxxxxx> wrote: > Eric Wong <normalperson@xxxxxxxx> writes: > > > Normally I would use "-D", but send-email (which normally passes options > > to format-patch) interprets the "-D" as a case-insensitive abbreviation > > for "--dry-run", preventing format-patch from seeing "-D". > > Is this nonstandard option that is designed to produce an > inapplicable patch so widely used to warrant a completion? > > I'd actually understand it if this were to complete "git show" and > friends, but not for format-patch. I'd actually think we might be > better off forbidding its use for the format-patch command (but not > for other commands in the "git log" family), not just at the > completion level but at the command line argument parser level. > > Hmph... I was actually hoping Paul would resurrect his work on getting apply to understand --irreversible-delete: http://mid.gmane.org/1343939748-12256-1-git-send-email-paul.gortmaker@xxxxxxxxxxxxx ($gmane/202789) I find this option useful to reduce mail traffic for others to review changes which are already pushed to a public repo. > > Signed-off-by: Eric Wong <normalperson@xxxxxxxx> > > --- > > Case-insensitivity strikes again! :< > > What a wacky default for Getopt::Long... And it's probably too late > > for us to disable case-insensitivity in CLI parsing for send-email. > > > > contrib/completion/git-completion.bash | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash > > index 2fece98..41d8ff8 100644 > > --- a/contrib/completion/git-completion.bash > > +++ b/contrib/completion/git-completion.bash > > @@ -1257,6 +1257,7 @@ __git_format_patch_options=" > > --not --all --cover-letter --no-prefix --src-prefix= --dst-prefix= > > --inline --suffix= --ignore-if-in-upstream --subject-prefix= > > --output-directory --reroll-count --to= --quiet --notes > > + --irreversible-delete > > " > > > > _git_format_patch () -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html