Re: diff: use built-in patterns by default via git attributes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 09, 2014 at 09:18:30PM +0100, Daniel Hahler wrote:

> I'm wondering why the built-in patterns (defined in userdiff.c) are not
> being applied by default, e.g. what you would normally do in
> core.attributesfile via:
> 
>     *.py diff=python
> 
> Wouldn't it make sense to provide certain defaults for attributes, where
> Git provides enhanced patterns?

It's been discussed:

  http://thread.gmane.org/gmane.comp.version-control.git/187269

It ended up with a lot of back-and-forth over which extensions belonged
to which type, and whether the C funcname pattern was terrible or not. I
got sick of it and dropped the patch.

You are welcome to try resurrecting it. :) It might help to read the
discussion and drop any contentious names. Since that thread, the C/C++
pattern has improved greatly, so it might not meet so much resistance.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]