On Fri, Dec 05, 2014 at 05:59:30PM -0500, Jeff King wrote: > On Fri, Dec 05, 2014 at 02:13:19PM -0800, Jonathan Nieder wrote: > > > Mike Hommey wrote: > > > > > I'm currently evaluating what the final tool would look like. I'm *very* > > > tempted to implement it in C, based on core git code, because there are > > > many things that this helper does that would be so much easier to do > > > with direct access to git's guts. And that wouldn't require more > > > dependencies than git currently has: it would "just" need curl and ssh, > > > and git already uses both. > > > > > > If I were to go in that direction, would you consider integrating it > > > in git core? > > > > Yes --- I would like this a lot. > > I'm concerned that this tool will have drawbacks that Felipe's remote-hg > does not. And I can well imagine that it may, as that tool builds on > Mercurial's API, which will probably handle some corner cases > differently. FWIW, my tool only uses the mercurial code for the wire protocol. This can (and if I go the C route, will) be implemented without using mercurial code, it's really not a hard problem. > This isn't to disparage Mike's attempt; it will probably > have some upsides, too. But given that the approaches are so different, > it does not seem obvious to me that one will always be better than the > other. > > One of the nice things about spinning remote-hg out of the core repo is > that it means we do not have to endorse a particular implementation, and > they can compete with each other on their merits. I would very much > hate to see Felipe's remote-hg project wither and die just because > another implementation becomes the de facto standard by being included > in git.git. It's a proven tool, and this new thing is not yet. Note that I'm only talking about an hypothetical long term goal. If there's not even a slim chance that this may end up in git core, or in the git.git repo, I'm not sure it's worth writing the tool in C at all, considering the burden for users. IOW, I'm only trying to assess if I should follow my temptation or not. But I can probably reassess after I actually get my prototype to do more than it does now. But maybe there are ways to make it work for users outside of git.git even if it's in C. I don't know. > It's a shame that both squat on the name "remote-hg", because it makes > it difficult to tell the two apart. But of course that is the only way > to make "git clone hg::..." work. Maybe we need a layer of indirection? > :) Yeah, that's an unfortunate consequence of how remote helpers work. There are already two different git-remote-hgs (there's felipe's, and there's another one using hg-git under the hood) that I know of. I'm adding a third one. For what it's worth, none of the existing one is satisfying on repos the size of Mozilla's, and apparently noone at Mozilla uses them because of that. Add to that the disk space inefficiency of actually keeping a copy of the mercurial repo locally. The existing tools can likely be improved to scale better, but that wouldn't change the disk space problem. Mike -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html