Eric Sunshine wrote: > On Wed, Dec 3, 2014 at 12:10 AM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: >> +void strbuf_prefixf(struct strbuf *sb, const char *fmt, ...) >> +{ >> + va_list ap; >> + size_t pos, len; >> + >> + pos = sb->len; >> + >> + va_start(ap, fmt); >> + strbuf_vaddf(sb, fmt, ap); >> + va_end(ap); >> + >> + len = sb->len - pos; >> + strbuf_insert(sb, 0, sb->buf + pos, len); >> + strbuf_remove(sb, pos + len, len); > > Would a strbuf_setlen(sb, pos), rather than strbuf_remove(), make it > clearer to the reader that this is merely performing a truncation? Good idea. I'll do that. Thanks, Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html