On Tue, Dec 2, 2014 at 7:11 AM, Duy Nguyen <pclouds@xxxxxxxxx> wrote:
> On Tue, Dec 2, 2014 at 2:32 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>> Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes:
>>
>>> This allows the callback to use 'base' as a temporary buffer to
>>> quickly assemble full path "without" extra allocation. The callback
>>> has to restore it afterwards of course.
>>
>> Hmph, what's the quote around 'without' doing there?
>
> because it's only true if you haven't used up all preallocated space
> in strbuf. If someone passes an empty strbuf, then underneath strbuf
> may do a few realloc until the buffer is large enough.
Would it be easier to understand if written like this?
This allows the callback to use 'base' as a temporary buffer to
quickly assemble full path, thus avoiding allocation/deallocation
for each iteration step.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html