Re: [PATCH] t0050-*.sh: mark the rename (case change) test as passing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 28, 2014 at 11:57 AM, Ramsay Jones
<ramsay@xxxxxxxxxxxxxxxxxxx> wrote:
> Since commit baa37bff ("mv: allow renaming to fix case on case
> insensitive filesystems", 08-05-2014), the 'git mv' command has
> been able to rename a file, to one which differs only in case,
> on a case insensitive filesystem.
>
> This results in the 'rename (case change)' test, which used to fail
> prior to this commit, to now (unexpectedly) pass. Mark this test as
> passing.
>
> Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxx>
> ---
>
> Hi Junio,
>
> I noticed this last week while testing on cygwin. I have only tested
> this on (64-bit) cygwin/ntfs, but I would assume that other case
> insensitive filesystems would be OK, since there have been no complaints
> about t6039-merge-ignorecase.sh not working.

I tested and verified that this patch is also needed on Mac OS X (as expected).

> Note that I didn't remove $test_case, despite having removed its last
> use in this test, in case there will be a future need. I'm not sure
> there will be a future need, of course, so if you would rather I got
> rid of it, just let me know.
>
> ATB,
> Ramsay Jones
>
>  t/t0050-filesystem.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t0050-filesystem.sh b/t/t0050-filesystem.sh
> index 6b3cedc..988c392 100755
> --- a/t/t0050-filesystem.sh
> +++ b/t/t0050-filesystem.sh
> @@ -64,7 +64,7 @@ test_expect_success "setup case tests" '
>         git checkout -f master
>  '
>
> -$test_case 'rename (case change)' '
> +test_expect_success 'rename (case change)' '
>         git mv camelcase CamelCase &&
>         git commit -m "rename"
>  '
> --
> 2.1.0
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]