Junio C Hamano <junkio@xxxxxxx> wrote: > I am wondering if "enum object_type" and signed comparison here > are compatible. sha1_object_info() is of type "int" so that is > clearly signed, but are we safe assuming this would not result > in "type is unsigned and condition is always false"? See my recent patch; I actually rewrote those hunks to use OBJ_BAD rather than < 0, as this cleans things up for my packv4. -- Shawn. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html