From: Ronnie Sahlberg <sahlberg@xxxxxxxxxx> Signed-off-by: Ronnie Sahlberg <sahlberg@xxxxxxxxxx> Signed-off-by: Stefan Beller <sbeller@xxxxxxxxxx> --- Changes v1->v2 * relocated the test from t1402 to t3200 * reword the commit message title to fit in with similar commits touching t/t3200-branch.sh Changes v2 -> v3 * remove space nit pointed out by Michael * simplified grep expression as pointed out by Torsten I don't mind applying this one later as part of the series, where we actually introduce the feature. Thanks for all the feedback! Michael writes > On the other hand, this is kind of an "aspirational test"; I don't > know that the tested functionality has ever worked or that anybody has > ever claimed that it works. So my feeling is that the addition of the > test would feel more natural in the patch series that implements the new > feature. But I don't feel strongly about it. I don't have a strong oppinion on this one either. It's just my impression, that small single patches are digested easier by the mailing list rather than large series. So as the feedback is in, I'll put this patch at the end of the series, where the actual feature will be introduced. t/t3200-branch.sh | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/t/t3200-branch.sh b/t/t3200-branch.sh index 432921b..fa7d7bd 100755 --- a/t/t3200-branch.sh +++ b/t/t3200-branch.sh @@ -163,6 +163,14 @@ test_expect_success 'git branch --list -d t should fail' ' test_path_is_missing .git/refs/heads/t ' +test_expect_failure 'git branch -d can delete ref with broken sha1' ' + echo "pointing nowhere" >.git/refs/heads/brokensha1 && + test_when_finished "rm -f .git/refs/heads/brokensha1" && + git branch -d brokensha1 && + git branch >output && + ! grep brokensha1 output +' + test_expect_success 'git branch --column' ' COLUMNS=81 git branch --column=column >actual && cat >expected <<\EOF && -- 2.2.0.rc3 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html