Jeff King <peff@xxxxxxxx> writes: > On Tue, Nov 25, 2014 at 11:51:28PM +0100, Øystein Walle wrote: > >> Signed-off-by: Øystein Walle <oystwa@xxxxxxxxx> >> --- >> t/t7503-pre-commit-hook.sh | 9 +++------ >> 1 file changed, 3 insertions(+), 6 deletions(-) >> >> diff --git a/t/t7503-pre-commit-hook.sh b/t/t7503-pre-commit-hook.sh >> index 984889b..99ed967 100755 >> --- a/t/t7503-pre-commit-hook.sh >> +++ b/t/t7503-pre-commit-hook.sh >> @@ -24,8 +24,7 @@ test_expect_success '--no-verify with no hook' ' >> HOOKDIR="$(git rev-parse --git-dir)/hooks" >> HOOK="$HOOKDIR/pre-commit" >> mkdir -p "$HOOKDIR" >> -cat > "$HOOK" <<EOF >> -#!/bin/sh >> +write_script "$HOOK" <<EOF > > While you are touching this line, please make it "<<\EOF". It does not > matter for these simple cases, but as a style, we try to avoid > interpolation unless it is necessary. Thanks. It is more about reducing cognitive burden from the readers. An unquoted <<EOF signals you that your eyes need to scan carefully for $subsitutions to understand what is going on, instead of coasting it over. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html