From: "Junio C Hamano" <gitster@xxxxxxxxx>
Philip Oakley <philipoakley@xxxxxxx> writes:
sub handleCompileLine
{
my ($line, $lineno) = @_;
- my @parts = split(' ', $line);
+ # my @parts = split(' ', $line);
+ my @parts = quotewords('\s+', 0, $line);
Can somebody enlighten me why/if quotewords is preferrable over
shellwords in the context of this patch?
"No" - Ignorance is bliss ;-) I think my cargo culting was the result of
some googling for "quoting perl variables" or some such, which obviously
came up with quotewords - I'm happy to take advice on this one!
quotewords did appear to work though back when I wrote this: 86dcfcf
(Properly accept quoted space in filenames, 2012-05-06)
--
Philip
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html