Stefan Beller wrote: > On Thu, Nov 20, 2014 at 1:20 PM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: >> I don't understand why the above writes to a temporary variable and >> checks it, never to read that temporary again. >> >> I don't think that alone is a reason to block the patch, but it >> worries me in that the review comment seems to have been just lost. > > It wasn't lost as I think it should go in a follow up patch. Sorry for > not stating that clearly. > (This patch is about moving code around, not changing code) Ah, sorry for the lack of clarity. I agree completely with the above principle. But the code that writes to result and checks result is new code, not part of the code that moved. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html