Stefan Beller <sbeller@xxxxxxxxxx> writes: > Junio, I'll address your proposed changes in a different patch. > If err is passed in as NULL, we'll just skip all the error string > formatting and return silent and fast. Huh, I lost track, but I never meant to say "the functions should return silently with error code when err == NULL". I said that it is another plausible expectation, hence justifies the comment to clarify, but wished that there were no need to clarify in the first place. If everybody required err != NULL, there would be no need to clarify which functions require err != NULL. If everybody accepted err == NULL as a more efficient way to do "--quiet", that is another way to remove the need to clarify. Either way is fine and I did not "propose" anything ;-). I think this matches more-or-less what I've locally tweaked after following the discussion between you and Jonathan. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html