Hi, The following patch series updates the reflog handling to use transactions. This patch series has previously been sent to the list[1]. This series converts the reflog handling and builtin/reflog.c to use a transaction for both the ref as well as the reflog updates. As a side effect of this it simplifies the reflog marshalling code so that we only have one place where we marshall the entry. It also means that we can remove several functions from the public api towards the end of the series since we no longer need those functions. This series can also be found at github[2] or at googlesource[3]. Feel free to review, where it suits you best. Version 3: * Go over the commit messages and reword them slightly where appropriate. (only cosmetics, like missing/double words, spelling, clarify) * As Ronnie announced to change employers soon, he'll have only limited time to work on git in the near future. As this is a rather large patch series, he is handing this work over to me. That's why I'm sending the patches this time. Thanks, Stefan [1] http://www.spinics.net/lists/git/msg241186.html [2] https://github.com/stefanbeller/git/tree/ref-transactions-reflog [3] https://code-review.googlesource.com/#/q/topic:ref-transaction-reflog Ronnie Sahlberg (14): refs.c: make ref_transaction_create a wrapper for ref_transaction_update refs.c: make ref_transaction_delete a wrapper for ref_transaction_update refs.c: rename the transaction functions refs.c: add a function to append a reflog entry to a fd refs.c: add a new update_type field to ref_update refs.c: add a transaction function to append a reflog entry refs.c: add a flag to allow reflog updates to truncate the log refs.c: only write reflog update if msg is non-NULL refs.c: allow multiple reflog updates during a single transaction reflog.c: use a reflog transaction when writing during expire refs.c: rename log_ref_setup to create_reflog refs.c: Remove unlock_ref/close_ref/commit_ref from the refs api refs.c: remove lock_any_ref_for_update refs.c: allow deleting refs with a broken sha1 branch.c | 13 +- builtin/branch.c | 5 +- builtin/checkout.c | 8 +- builtin/commit.c | 10 +- builtin/fetch.c | 12 +- builtin/receive-pack.c | 13 +- builtin/reflog.c | 85 ++++------ builtin/replace.c | 10 +- builtin/tag.c | 10 +- builtin/update-ref.c | 26 +-- cache.h | 7 + fast-import.c | 22 +-- refs.c | 403 +++++++++++++++++++++++++++++--------------- refs.h | 87 +++++----- sequencer.c | 12 +- t/t1402-check-ref-format.sh | 8 + walker.c | 10 +- 17 files changed, 440 insertions(+), 301 deletions(-) -- 2.2.0.rc2.5.gf7b9fb2 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html